Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Next.js-specific bundling information #27444

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Feb 4, 2025

What does this PR do? What is the motivation?

The document already has a bundling section describing Esbuild, but a lot of customers encounter the same problem with Next.js, so we should provide Next.js-specific information too to have easily accessible piece of knowledge about it that we can point them to.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

JIRA: PROF-11291

@szegedi szegedi requested a review from a team as a code owner February 4, 2025 16:12
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Preview links (active after the build_preview check completes)

Modified Files

@drichards-87
Copy link
Contributor

Created DOCS-10008 for the editorial review.

@drichards-87 drichards-87 added the editorial review Waiting on a more in-depth review label Feb 4, 2025
@szegedi szegedi requested a review from tlhunter February 5, 2025 15:06
@szegedi szegedi requested a review from tlhunter February 6, 2025 11:08
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@szegedi
Copy link
Contributor Author

szegedi commented Feb 7, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-07 16:34:33 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-02-07 16:40:22 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 7d378d5 into master Feb 7, 2025
20 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the szegedi/next-js branch February 7, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants