Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server.md #27484

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update server.md #27484

wants to merge 3 commits into from

Conversation

mkelleh2
Copy link

@mkelleh2 mkelleh2 commented Feb 6, 2025

Recommended change for RUM auto-instrumentation doc to clarify pre-requisites section, making it clearer that APM is a pre-req.

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Recommended change for RUM auto-instrumentation doc to clarify pre-requisites section, making it clearer that APM is a pre-req.
@mkelleh2 mkelleh2 requested review from a team as code owners February 6, 2025 18:48
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the branch name. I left a minor suggestion on the wording.

content/en/real_user_monitoring/browser/setup/server.md Outdated Show resolved Hide resolved
@mkelleh2
Copy link
Author

mkelleh2 commented Feb 6, 2025

Great suggestion. I like it.

@drichards-87
Copy link
Contributor

@mkelleh2 Just FYI, I pinged the rum-browser team and asked them to review/approve this PR. I'll merge it as soon as they do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants