Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Node.js profiler troubleshooting page #27503

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Feb 7, 2025

What does this PR do? What is the motivation?

Profilers for all languages have a troubleshooting page, only Node.js didn't have one. Since we're encountering some repeated support questions for Node.js, it's very useful to have a page that collects the usual answers to the more frequent ones.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

JIRA: PROF-11319

@szegedi szegedi requested a review from a team as a code owner February 7, 2025 13:03
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Preview links (active after the build_preview check completes)

New or renamed files

Error: No native build was found for runtime=node abi=109 platform=linuxglibc arch=x64
```

If you are using a bundler such as esbuild or webpack (used by e.g. Next.js), refer to [Bundling with the Node.js tracer][3]. Datadog tracer and profiler have special requirements when used with bundlers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thinking adding this.

Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for adding this.
Some minor lints might be worth considering.

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Feb 7, 2025
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this to the docs! Left some suggestions, let me know if you have any questions!

@szegedi szegedi requested a review from estherk15 February 10, 2025 10:45
@szegedi
Copy link
Contributor Author

szegedi commented Feb 10, 2025

Thank you for the suggestions, @estherk15 ! I started working on the linter suggestions on Friday myself but didn't finish by EOD. Your reformulations are anyway better :-) . I applied them all.

@estherk15
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 10, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-10 17:00:07 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-02-10 17:06:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 1102526 into master Feb 10, 2025
18 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the szegedi/nodejs-profiler-troubleshoot branch February 10, 2025 17:06
domalessi pushed a commit that referenced this pull request Feb 12, 2025
* Add a Node.js profiler troubleshooting page

* Fix a copy-paste

* Add to the troubleshooting sidebar

* Apply suggestions from review

Co-authored-by: Esther Kim <[email protected]>

---------

Co-authored-by: Esther Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants