-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Node.js profiler troubleshooting page #27503
Conversation
Preview links (active after the
|
Error: No native build was found for runtime=node abi=109 platform=linuxglibc arch=x64 | ||
``` | ||
|
||
If you are using a bundler such as esbuild or webpack (used by e.g. Next.js), refer to [Bundling with the Node.js tracer][3]. Datadog tracer and profiler have special requirements when used with bundlers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good thinking adding this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for adding this.
Some minor lints might be worth considering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this to the docs! Left some suggestions, let me know if you have any questions!
Co-authored-by: Esther Kim <[email protected]>
Thank you for the suggestions, @estherk15 ! I started working on the linter suggestions on Friday myself but didn't finish by EOD. Your reformulations are anyway better :-) . I applied them all. |
/merge |
Devflow running:
|
* Add a Node.js profiler troubleshooting page * Fix a copy-paste * Add to the troubleshooting sidebar * Apply suggestions from review Co-authored-by: Esther Kim <[email protected]> --------- Co-authored-by: Esther Kim <[email protected]>
What does this PR do? What is the motivation?
Profilers for all languages have a troubleshooting page, only Node.js didn't have one. Since we're encountering some repeated support questions for Node.js, it's very useful to have a page that collects the usual answers to the more frequent ones.
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes
JIRA: PROF-11319