Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics streams filtering support #28288

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rmshree
Copy link
Contributor

@rmshree rmshree commented Mar 21, 2025

What does this PR do? What is the motivation?

We now support tag filtering for metrics sent through streams as well

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. Your branch name MUST follow the <slack_username>/<branch_name> convention, or your pull request will not pass in CI. If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@rmshree rmshree requested a review from a team as a code owner March 21, 2025 14:52
@github-actions github-actions bot added the Guide Content impacting a guide label Mar 21, 2025
Copy link
Contributor

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small edit

…th-kinesis-data-firehose.md

Co-authored-by: Heston Hoffman <[email protected]>
@rmshree
Copy link
Contributor Author

rmshree commented Mar 21, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 21, 2025

View all feedbacks in Devflow UI.
2025-03-21 18:17:21 UTC ℹ️ Start processing command /merge


2025-03-21 18:17:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-21 22:18:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide mergequeue-status: removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants