-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-10418 #28319
DOCS-10418 #28319
Conversation
Preview links (active after the
|
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
|
||
#### Use workload selection (recommended) | ||
|
||
With workload selection, you can enable and disable tracing for specific applications. [See configuration details here](#advanced-options). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if there's a way to link to the explicit panel that can open because when you go here it throws you back to the top of the entire section and is a little confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel pretty good about shipping these changes and then doing any other updates in a follow up!
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor nits. Approved!
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/automatic_instrumentation/single-step-apm/_index.md
Outdated
Show resolved
Hide resolved
|
||
Review the following examples demonstrating how to select specific services: | ||
|
||
{{< collapse-content title="Example 1: Enable all namespaces except one" level="h4" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal preference, don't need to specify Example # in the collapse content
@@ -520,7 +722,15 @@ To remove APM instrumentation and stop sending traces from a specific service, f | |||
2. Restart the service. | |||
{{% /tab %}} | |||
|
|||
{{% tab "Kubernetes" %}} | |||
{{% tab "Kubernetes (Preview)" %}} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these two methods of removing instrumentation on Kubernetes? Like either or? Or do both of these? Recommend a sentence to clarify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a sentence:
As an alternative, or for a version of the agent that does not support workload selection, you can also disable pod mutation by adding a label to your pod.
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
…rgets config instructions
…single-step-apm/_index.md Co-authored-by: Stan Rozenraukh <[email protected]>
…single-step-apm/_index.md Co-authored-by: Stan Rozenraukh <[email protected]>
Fixing whitespace and a couple of yamls
…single-step-apm/_index.md
…single-step-apm/_index.md Co-authored-by: Esther Kim <[email protected]>
…single-step-apm/_index.md Co-authored-by: Esther Kim <[email protected]>
…single-step-apm/_index.md Co-authored-by: Esther Kim <[email protected]>
…single-step-apm/_index.md Co-authored-by: Esther Kim <[email protected]>
c456595
to
18a0c6b
Compare
What does this PR do? What is the motivation?
https://datadoghq.atlassian.net/browse/DOCS-10418
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. Your branch name MUST follow the
<slack_username>/<branch_name>
convention, or your pull request will not pass in CI. If your branch doesn't follow this format, rename it or create a new branch and PR.To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes