Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-10418 #28319

Merged
merged 22 commits into from
Mar 27, 2025
Merged

DOCS-10418 #28319

merged 22 commits into from
Mar 27, 2025

Conversation

domalessi
Copy link
Contributor

@domalessi domalessi commented Mar 24, 2025

What does this PR do? What is the motivation?

https://datadoghq.atlassian.net/browse/DOCS-10418

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. Your branch name MUST follow the <slack_username>/<branch_name> convention, or your pull request will not pass in CI. If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@domalessi domalessi added the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 24, 2025
@domalessi domalessi requested a review from a team as a code owner March 24, 2025 17:59
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files


#### Use workload selection (recommended)

With workload selection, you can enable and disable tracing for specific applications. [See configuration details here](#advanced-options).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there's a way to link to the explicit panel that can open because when you go here it throws you back to the top of the entire section and is a little confusing.

Copy link
Member

@stanistan stanistan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel pretty good about shipping these changes and then doing any other updates in a follow up!

@stanistan stanistan removed the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 27, 2025
@estherk15 estherk15 self-assigned this Mar 27, 2025
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nits. Approved!


Review the following examples demonstrating how to select specific services:

{{< collapse-content title="Example 1: Enable all namespaces except one" level="h4" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal preference, don't need to specify Example # in the collapse content

@@ -520,7 +722,15 @@ To remove APM instrumentation and stop sending traces from a specific service, f
2. Restart the service.
{{% /tab %}}

{{% tab "Kubernetes" %}}
{{% tab "Kubernetes (Preview)" %}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two methods of removing instrumentation on Kubernetes? Like either or? Or do both of these? Recommend a sentence to clarify

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a sentence:

As an alternative, or for a version of the agent that does not support workload selection, you can also disable pod mutation by adding a label to your pod.

@stanistan
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 27, 2025

View all feedbacks in Devflow UI.
2025-03-27 19:37:54 UTC ℹ️ Start processing command /merge


2025-03-27 19:38:02 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-27 20:08:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 17m (p90).


2025-03-27 21:02:27 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants