Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor formatting issues in trace metrics documentation #28395

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

t5kaji
Copy link
Contributor

@t5kaji t5kaji commented Mar 27, 2025

What does this PR do? What is the motivation?

This PR fixes minor formatting inconsistencies in the trace metrics documentation, including

  • Ensuring the Note block is visually separated from the description
  • Displaying Metric Type as a separate block for better clarity
  • Renaming XRay to X-Ray to align with the official naming

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@t5kaji t5kaji requested a review from a team as a code owner March 27, 2025 08:20
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@t5kaji
Copy link
Contributor Author

t5kaji commented Mar 27, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 27, 2025

View all feedbacks in Devflow UI.
2025-03-27 08:46:14 UTC ℹ️ Start processing command /merge


2025-03-27 08:46:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-27 12:47:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@estherk15
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 27, 2025

View all feedbacks in Devflow UI.
2025-03-27 16:49:56 UTC ℹ️ Start processing command /merge


2025-03-27 16:50:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 16m (p90).


2025-03-27 17:51:27 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 4af28dc into master Mar 27, 2025
20 of 27 checks passed
@dd-mergequeue dd-mergequeue bot deleted the takuya.kajiwara/fix-trace-metrics-formatting branch March 27, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants