Skip to content

Fix AWS Data Firehose environment variable #28738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

codyborders
Copy link
Contributor

Updates the environment variable to DD_OP_SOURCE_AWS_DATA_FIREHOSE_ADDRESS as what's currently in the documentation will lead to errors.

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Updates the environment variable to `DD_OP_SOURCE_AWS_DATA_FIREHOSE_ADDRESS` as what's currently in the documentation will lead to errors.
@codyborders codyborders requested a review from a team as a code owner April 11, 2025 23:16
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Apr 11, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codyborders
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 14, 2025

View all feedbacks in Devflow UI.

2025-04-14 14:08:58 UTC ℹ️ Start processing command /merge


2025-04-14 14:09:11 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-14 14:34:23 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 18m (p90).


2025-04-14 14:50:13 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit ee85ccf:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend mergequeue-status: rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants