Skip to content

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented Oct 9, 2025

What does this PR do? What is the motivation?

Update setup instructions with new options and structure.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@buraizu buraizu requested a review from a team as a code owner October 9, 2025 01:05
@buraizu buraizu added the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 9, 2025
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Preview links (active after the build_preview check completes)

Modified Files


1. In the [Google Cloud integration page][500], select **+ Add GCP Account**.
2. Select **Terraform**.
3. Under **Provide GCP Resources**, add any project and folder IDs to be monitored.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update project to project IDs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would omit you can see projects and folders that you have required access and permission for in the terraform flow; unlike the Quickstart option they won't see their folders or projects in the datadog UI

@tedkahwaji tedkahwaji requested a review from dtru-ddog October 9, 2025 13:19
2. Click **Copy** in the setup script section.
3. Click **Open Google Cloud Shell**.
4. Paste the script into the shell prompt and run it.
**Note**: Datadog recommends running this script locally through the [gcloud CLI][201], as it may be faster. This requires having your Google Cloud credentials available locally, and the gcloud CLI installed on your machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this NOTE below step 2 before the customer opens up the Gcloud Shell

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 74b574b

1. In the [Google Cloud integration page][200], select **+ Add GCP Account**.
2. Click **Quick Start**.
2. Click **Copy** in the setup script section.
3. Click **Open Google Cloud Shell**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a link here for the customer https://ssh.cloud.google.com/cloudshell

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not critical, since a user would theoretically have the tile open---but it couldn't hurt, so I've added this in 74b574b

Copy link
Contributor

@dtru-ddog dtru-ddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of additional requests, let me know what you think


1. In the [Google Cloud integration page][200], select **+ Add GCP Account**.
2. Click **Quick Start**.
2. Click **Copy** in the setup script section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this be a 3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging!

6. Under **Provide Service Account Details**:
1. Give the service account a name.
2. Select the project to contain the service account.
7. Optionally, configure **Metric Collection**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Kind of prefer moving the optionality to the end

Suggested change
7. Optionally, configure **Metric Collection**.
7. Configure **Metric Collection** [OPTIONAL]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 74b574b

3. Choose whether to disable metric collection for specific Google Cloud services to help control Google Cloud Monitoring costs.
4. Choose whether to filter metrics by tags for GCP resource types `Cloud Run Revision`, `VM Intance`, or `Cloud Function` to help control Datadog costs.
7. Optionally, choose to disable **Resource Collection** (attributes and configuration information of the resources in your Google Cloud environment).
8. Copy the provided **Terraform Code**. If confirmed, the script:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the second sentence here is off, not sure what we're trying to convey

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what specifically is off, these are the options displayed in the UI:
gcp_resource_types

Did you mean something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gcp-integrations WORK IN PROGRESS No review needed, it's a wip ;)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants