-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update agent-filtering-for-dogstatsd-custom-metrics.md with remote config + RBAC details #32104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nfig + RBAC details
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions. Let me know if you have any Qs, and hit me up for re-review when ready!
content/en/metrics/guide/agent-filtering-for-dogstatsd-custom-metrics.md
Outdated
Show resolved
Hide resolved
- Ensure that your RBAC permissions include [`org_management`][2] and that [Remote Configuration][3] is enabled for your organization. | ||
- Ensure that your RBAC permissions include [`api_keys_write`][4] and that the [Remote Configuration capability is enabled on the API keys][5] used by your Agents. After enabling Remote Configuration on an API key, an Agent restart is required for Remote Configuration enablement to take effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Ensure that your RBAC permissions include [`org_management`][2] and that [Remote Configuration][3] is enabled for your organization. | |
- Ensure that your RBAC permissions include [`api_keys_write`][4] and that the [Remote Configuration capability is enabled on the API keys][5] used by your Agents. After enabling Remote Configuration on an API key, an Agent restart is required for Remote Configuration enablement to take effect. | |
- Ensure that your RBAC permissions include [`org_management`][2] and [`api_keys_write`][4]. | |
- Enable [Remote Configuration][3] for your organization. | |
- Enable the Remote Configuration capability on the API keys][5] used by your Agents. After enabling Remote Configuration on an API key, an Agent restart is required for Remote Configuration enablement to take effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean to communicate with this structure is that, respectively:
- the
org_management
permission is only needed to validate that Remote Configuration is enabled for the org (and if not, to enable it) - the
api_keys_write
permission is only needed to validate that the API keys have Remote Configuration enabled (and if not, enable it on them)
but that these permissions are not needed to use the feature, they're only needed during the initial setup.
I'm under the impression that your proposed changes would make this less clear. But I'm also open to suggestions on how to make this more explicit/clear. WDYT?
content/en/metrics/guide/agent-filtering-for-dogstatsd-custom-metrics.md
Outdated
Show resolved
Hide resolved
content/en/metrics/guide/agent-filtering-for-dogstatsd-custom-metrics.md
Outdated
Show resolved
Hide resolved
Co-authored-by: domalessi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do? What is the motivation?
For Remote Config: I re-used and simplified the enablement instructions documented for APM tracing's RC setup: https://docs.datadoghq.com/tracing/guide/remote_config/
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes