-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update OP OTel default port #32952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update OP OTel default port #32952
Conversation
Preview links (active after the
|
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions!
Co-authored-by: domalessi <[email protected]>
domalessi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Looks great :)
| ## Send logs to the Observability Pipelines Worker | ||
|
|
||
| Configure your OTel exporters to point to HTTP or gRPC. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add this right after this line at the top: "Configure your OTel exporters to point to HTTP or gRPC"
"The Worker exposes configurable listener ports for each protocol.
Note: The ports 4318 (HTTP) and 4317 (gRPC) shown below are examples only. You can configure the port values for either protocol in the Worker. Ensure your OTel exporters match whatever port you choose."
Is it possible to make the Note a callout like we do here: https://docs-staging.datadoghq.com/may/otel-default-port/observability_pipelines/#observability-pipelines-worker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated and added note callout.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes