Clarify reserved service attribute behavior - #39720
Open
wjiang720 wants to merge 3 commits into
Open
Conversation
Contributor
Preview links (active after the
|
joepeeples
approved these changes
Sep 3, 2026
| - V1 selects the first `service` tag it processes. Because tags are not sorted, the result is not deterministic. | ||
| - V2 sorts the tags alphabetically and selects the first `service` tag. | ||
|
|
||
| For example, consider an event with `env:prod`, `service:payments`, `team:store`, and `service:checkout`. V1 can assign either service value. V2 assigns `checkout`, because `service:checkout` comes before `service:payments` alphabetically. |
Contributor
There was a problem hiding this comment.
Suggested change
| For example, consider an event with `env:prod`, `service:payments`, `team:store`, and `service:checkout`. V1 can assign either service value. V2 assigns `checkout`, because `service:checkout` comes before `service:payments` alphabetically. | |
| For example, consider an event with `env:prod`, `service:payments`, `team:store`, and `service:checkout`. V1 can assign either `service` value. V2 assigns `checkout`, because `service:checkout` comes before `service:payments` alphabetically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Clarifies how the reserved
serviceattribute behaves when an event contains multipleservicetags. Recommends sending oneservicetag per event, explains how to represent additional dimensions, and distinguishes reserved-attribute searches from raw-tag searches.Merge readiness
For Datadog employees:
<name>/<description>convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR./reviewto run an automated check that catches common issues before a Documentation team member reviews your PR.AI assistance
AI assistance was used to identify the documentation gap and draft the clarification.
Additional notes