-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIPS compliant v3.5.17-dd.2
build
#10
base: release-3.5-dd-v3.5.17-dd.2-fips
Are you sure you want to change the base?
FIPS compliant v3.5.17-dd.2
build
#10
Conversation
9522d28
to
ecdf7ca
Compare
Signed-off-by: Benjamin Wang <[email protected]>
Signed-off-by: Benjamin Wang <[email protected]>
Signed-off-by: joshjms <[email protected]> change go directive to 1.23 Signed-off-by: joshjms <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
f82296c
to
08ab516
Compare
- "windows/arm64" | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)
Pin GitHub Actions by commit hash to ensure supply chain security.
Using a branch (@main
) or tag (@v1
) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
shell: bash | ||
working-directory: release/ | ||
run: ls . | grep -E '\.tar.gz$|\.zip$' | xargs shasum -a 256 > ./SHA256SUMS | ||
- uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)
Pin GitHub Actions by commit hash to ensure supply chain security.
Using a branch (@main
) or tag (@v1
) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
ef8ca58
to
3438b26
Compare
- name: Create output directory | ||
run: mkdir -p _output/checksums | ||
- name: Download all artifacts | ||
uses: actions/download-artifact@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)
Pin GitHub Actions by commit hash to ensure supply chain security.
Using a branch (@main
) or tag (@v1
) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
3438b26
to
57dc0c7
Compare
echo "ARTIFACT_NAME=etcd_output_amd64" >> $GITHUB_ENV | ||
fi | ||
- name: Download artifacts | ||
uses: actions/download-artifact@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)
Pin GitHub Actions by commit hash to ensure supply chain security.
Using a branch (@main
) or tag (@v1
) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
3036440
to
b22336f
Compare
f10fa56
to
d92b212
Compare
|
d92b212
to
be893a6
Compare
What's changing in
.github/workflows/dd-build.yaml
build
job is split up intobuild-arm64
andbuild-amd64
CGO_ENABLED=1
and I was having issues cross-compiling. Thebuild-arm64
job runs on anarm64
machine andbuild-amd64
job runs on anamd64
machine. I use a matrix strategy for both rather than hardcoding environment variables.etcd_output_arm64
andetcd_output_amd64
build-amd64
andbuild-arm64
Set artifact name
to set the name of the artifact to be downloaded properly inreleaseassets
.releaseassets
-->releaseassetsarm
New script
./scripts/build-release-single-target
./scripts/build-binary
etcd
and creates a.tar.gz
release artifact.TARGET_OS
andTARGET_ARCH
to build the binaryModifications to
build.sh
GO_ADDITIONAL_VARS
included inGO_BUILD_ENV
GOEXPERIMENT=boringcrypto
export GOEXPERIMENT=boringcrypto
, but it didn't work (see 57dc0c7 and https://github.com/DataDog/etcd/actions/runs/13862426254/job/38793868704)Added
fips.go
toetcd
,etcdctl
,etcdutl
main
packages