Fixes InstanceConfig model generation when validators functions are defined in spec.yaml #21409
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes an issue where our config model_file generation currently uses an incorrect package for executing validators defined in spec.yaml stanzas. We're currently incorrectly using
validation
package (from datadog_checks.base.utils.models import validation
) instead ofvalidators
(from . import defaults, validators
) so we get anAttributeError
The fix is clearer if you expand the test that was modified. You can see how the input spec maps to the generated
instance_model_contents
Searching across integrations-core and integrations-extras for validators usage in yaml files seems to show that no integration currently uses this functionality which is why its been missed until now
Motivation
We're working on fixing up the Postgres / DBM integration configs to be fully using the Pydantic models and validate the configs for exposing DBM healthcheck events and unable to use these validators files.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged