Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lint #276

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix clippy lint #276

merged 1 commit into from
Oct 25, 2023

Conversation

paullegranddc
Copy link
Contributor

@paullegranddc paullegranddc commented Oct 25, 2023

What does this PR do?

Fix a small clippy lint

Motivation

The tarpc code has been vendored because we forked it with minimal changes, and the fact that package managers didn't want us to depend on other github repositories to distribute libdatadog.

I wish we had a way to disable the clippy lint just for tarpc, without having to diverge further from upstream but it looks like it's not possible.

@paullegranddc paullegranddc requested a review from a team as a code owner October 25, 2023 13:11
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@paullegranddc paullegranddc merged commit b5eddd6 into main Oct 25, 2023
danielsn pushed a commit that referenced this pull request Oct 27, 2023
@bantonsson bantonsson deleted the paullgdc/fix_clippy_lint_in_tarpc branch March 7, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants