This repository was archived by the owner on Oct 21, 2024. It is now read-only.
Support emitting distribution metrics alongside or instead of histograms #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tebriel
force-pushed
the
optional-distributions
branch
from
54d5ff4 to
20afb0e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to move to using distributions instead of histograms, but this library didn't support that feature. There's a new option for
timing_typewhich acceptshistogram,distribution, orboth. We usedbothto make sure our monitors worked with the new data and that the new data was what we wanted, then switched todistribution. Wanted to contribute this back in case it could get merged in!