Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Puppet 8 and PDK version to 3.4 #823

Merged
merged 155 commits into from
Mar 10, 2025

Conversation

xenon8
Copy link
Contributor

@xenon8 xenon8 commented Dec 23, 2024

This will update the Puppet syntax for module to v8 of Puppet; I have updated the reference to StdLib to v9 as well (as this is the version that supports Puppet 8).

I used the PDK for this update; resulting me updating the PDK files also, I had to merge your existing code into the PDK 3.4 template, please let me know if I missed something.

@xenon8 xenon8 requested review from a team as code owners December 23, 2024 09:50
… bcrypt_pbkdf 1.1 fails to install with Ruby 3.2.5
@xenon8 xenon8 changed the title upgrade pdk version to 3.4 upgrade to Puppet 8 and PDK version to 3.4 Dec 23, 2024
Copy link
Contributor

@nielstholenaar nielstholenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on the Puppet 8 version.

I'm currently in the process of upgrading our Puppet server and this module was one of the modules that lacked support. I have added some fixes for things I experienced while using your version.

Bump kitchen test images for CentOS and Rocky Linux
@xenon8 xenon8 requested a review from a team as a code owner March 8, 2025 15:40
Copy link
Contributor

@fanny-jiang fanny-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback for your review!

@fanny-jiang fanny-jiang requested a review from rtrieu March 10, 2025 19:55
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@fanny-jiang fanny-jiang merged commit 12db4ae into DataDog:main Mar 10, 2025
12 checks passed
@xenon8 xenon8 deleted the xenon8/puppet-8-upgrade branch March 10, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants