-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to Puppet 8 and PDK version to 3.4 #823
Conversation
…ve legacy :: referencing. Changes for Puppet 8
… prettied the code.
…g no check for empty strings
… bcrypt_pbkdf 1.1 fails to install with Ruby 3.2.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on the Puppet 8 version.
I'm currently in the process of upgrading our Puppet server and this module was one of the modules that lacked support. I have added some fixes for things I experienced while using your version.
Bump kitchen test images for CentOS and Rocky Linux
Clean up legacy Agent 5 code
…uppet-datadog-agent into xenon8/puppet-8-upgrade
Address linter warnings
add back redis ssl
…uppet-datadog-agent into xenon8/puppet-8-upgrade
Fix postgres and elastic, agent 5 cleanups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback for your review!
Co-authored-by: Rosa Trieu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This will update the Puppet syntax for module to v8 of Puppet; I have updated the reference to StdLib to v9 as well (as this is the version that supports Puppet 8).
I used the PDK for this update; resulting me updating the PDK files also, I had to merge your existing code into the PDK 3.4 template, please let me know if I missed something.