Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tcp_check for multi instances #851

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Fix tcp_check for multi instances #851

merged 2 commits into from
Mar 24, 2025

Conversation

fanny-jiang
Copy link
Contributor

@fanny-jiang fanny-jiang commented Mar 13, 2025

What does this PR do?

Fix bug introduced in v4 of the module which broke multi instances support in the tcp_check.

Motivation

Fixes #849

Additional Notes

Describe your test plan

@fanny-jiang fanny-jiang requested review from a team as code owners March 13, 2025 22:12
host: 'baz.bar.foo',
port: '8080',
timeout: 456,
tags: ['foo', 'bar', 'baz']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

Suggested change
tags: ['foo', 'bar', 'baz']
tags: %w[foo bar baz]
Consider using the %w syntax instead (...read more)

The rule "Prefer %w to the literal array syntax" is a Ruby style guideline that encourages the use of %w notation instead of the traditional array syntax when defining arrays of strings. This rule is part of the Ruby community's efforts to promote readability and simplicity in Ruby code.

This rule is important because it helps to keep the code concise and easy to read. The %w notation allows you to define an array of strings without having to use quotes and commas. This can make the code cleaner and easier to understand, especially when dealing with large arrays.

To follow this rule, replace the traditional array syntax with the %w notation. For example, instead of writing ['foo', 'bar', 'baz'], you should write %w[foo bar baz]. This will create the same array, but in a more readable and concise way. By following this rule, you can help to make your Ruby code cleaner and easier to understand.

View in Datadog  Leave us feedback  Documentation

@fanny-jiang fanny-jiang merged commit d2da2f8 into main Mar 24, 2025
12 checks passed
@fanny-jiang fanny-jiang deleted the fanny/fix-tcp-check branch March 24, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tcp_check requires parameters as mandatory since 4.0.0 that should not be mandatory
2 participants