stability: remediate validated findings across core, go, and docs - #28
Merged
Conversation
Apply the validated findings remediation set to harden sync/uploader behavior, close reliability gaps in CI/integration tests, and align user-facing docs/examples with the implemented contracts.
|
✨ Fix all issues with BitsAI or with Cursor
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Comment on lines
+226
to
+229
| if additional_items is False: | ||
| errors.append(f"{path}[{idx}]: additional item not allowed") | ||
| elif isinstance(additional_items, dict): | ||
| _validate(item, additional_items, root, f"{path}[{idx}]", errors) |
There was a problem hiding this comment.
🔴 High: Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
Align maintainer guidance with actual repo test/build entrypoints and add targeted edge-case coverage/documentation to close the final findings audit gaps.
Resolve settings.json discovery in the mock-server harness across Git Bash and Bazel Windows path variants to avoid false negatives in Windows CI.
Create an empty follow-up commit so PR checks re-evaluate on the latest branch head while investigating stale Windows CI status propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
items, env/command escaping, mock server behavior, and example dry-run execution) and align CI to execute those paths.Test plan
./bazelw test //tools/tests/core:testscd modules/go && ../../bazelw test //tests:tests --override_module=datadog-rules-test-optimization=../.../bazelw test //tools/...cd modules/go && ../../bazelw test //... --override_module=datadog-rules-test-optimization=../.../bazelw test //examples/..../tools/tests/integration/run_mock_server_tests.sh