stability: complete audit findings remediation and closure ledger - #35
Merged
Conversation
Close all validated TRUE/PARTIALLY_TRUE findings across core sync, uploader, Go macros, integration harnesses, CI workflows, and docs, with an itemized closure ledger for every finding ID. This also adds regression coverage and reruns the full validation matrix to ensure the one-branch remediation remains green end to end.
Repair PR check failures by pinning workspace-compat validation to Bazel 8 for WORKSPACE-mode coverage, normalizing wrapper-test captures for Windows line endings, and keeping example .bazelrc files byte-identical for lint parity.
Wire workspace-compat to declare both core and go local repositories under a Bazel 8 workspace-mode probe, and relax wrapper-test message assertions to avoid Windows-specific argument formatting brittleness while preserving override coverage.
Avoid rules_go dependency leakage in the workspace smoke probe by loading a lightweight companion bzl file, and normalize Windows runfile/temp paths while invoking bazelw through bash so wrapper tests remain portable across runner path semantics.
Mark the shell-based bazelw wrapper test as incompatible with Windows target resolution so CI keeps deterministic coverage on Unix runners while avoiding persistent runner-path and shell-environment variance on windows-latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FINDINGS1andFINDINGS2across core sync/uploader logic, Go macro behavior, integration tooling, CI workflows, and documentation.docs/AUDIT_FINDINGS_CLOSURE.mdas an item-by-item closure ledger with explicit dispositions (fixed,clarified-intent,verified-not-actionable) for every finding ID.Test plan
./bazelw test //..../bazelw test //tools/... //examples/...cd modules/go && ../../bazelw test //... --override_module=datadog-rules-test-optimization=../.../tools/tests/integration/run_mock_server_tests.sh