fix: enable http feature flag for bollard
#515
Conversation
Regression Detector (DogStatsD)Regression Detector ResultsRun ID: 4276b717-d71f-4097-956e-d36da51bd894 Baseline: 7.63.0-rc.6 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | +1.59 | [+1.42, +1.75] | 1 | |
| ➖ | quality_gates_idle_rss | memory utilization | +1.33 | [+1.22, +1.45] | 1 | |
| ➖ | dsd_uds_40mb_12k_contexts_40_senders | ingress throughput | +0.00 | [-0.00, +0.01] | 1 | |
| ➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | |
| ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | |
| ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | |
| ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | +0.00 | [-0.00, +0.00] | 1 | |
| ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | |
| ➖ | dsd_uds_1mb_3k_contexts_dualship | ingress throughput | -0.00 | [-0.00, +0.00] | 1 | |
| ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | -0.00 | [-0.05, +0.04] | 1 | |
| ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | -0.01 | [-0.02, +0.01] | 1 | |
| ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | -3.81 | [-3.95, -3.68] | 1 |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | quality_gates_idle_rss | memory_usage | 0/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Regression Detector (Saluki)Regression Detector ResultsRun ID: 4dedfdbc-66c5-451e-b1d0-1b84d8f26878 Baseline: 736d0d9 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | dsd_uds_500mb_3k_contexts | ingress throughput | +0.67 | [+0.55, +0.79] | 1 | |
| ➖ | dsd_uds_100mb_3k_contexts_distributions_only | memory utilization | +0.15 | [+0.04, +0.26] | 1 | |
| ➖ | dsd_uds_100mb_3k_contexts | ingress throughput | +0.01 | [-0.04, +0.05] | 1 | |
| ➖ | dsd_uds_1mb_3k_contexts_dualship | ingress throughput | +0.01 | [-0.00, +0.02] | 1 | |
| ➖ | quality_gates_idle_rss | memory utilization | +0.01 | [-0.02, +0.03] | 1 | |
| ➖ | dsd_uds_40mb_12k_contexts_40_senders | ingress throughput | +0.00 | [-0.03, +0.03] | 1 | |
| ➖ | dsd_uds_100mb_250k_contexts | ingress throughput | +0.00 | [-0.03, +0.04] | 1 | |
| ➖ | dsd_uds_1mb_50k_contexts | ingress throughput | -0.00 | [-0.00, +0.00] | 1 | |
| ➖ | dsd_uds_1mb_3k_contexts | ingress throughput | -0.01 | [-0.02, +0.01] | 1 | |
| ➖ | dsd_uds_512kb_3k_contexts | ingress throughput | -0.01 | [-0.02, +0.00] | 1 | |
| ➖ | dsd_uds_50mb_10k_contexts_no_inlining | ingress throughput | -0.01 | [-0.08, +0.06] | 1 | |
| ➖ | dsd_uds_10mb_3k_contexts | ingress throughput | -0.02 | [-0.04, +0.01] | 1 | |
| ➖ | dsd_uds_50mb_10k_contexts_no_inlining_no_allocs | ingress throughput | -0.03 | [-0.09, +0.04] | 1 | |
| ➖ | dsd_uds_1mb_50k_contexts_memlimit | ingress throughput | -1.05 | [-1.28, -0.81] | 1 |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | quality_gates_idle_rss | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Regression Detector LinksExperiment Result Links
|
Summary
As part of the upgrade to
bollard0.18.x, there was a change in the default features exposed which are now required to support specific I/O transports out-of-the-box.This PR simply enables the
httpfeature flag to add support back for connecting to the Docker daemon over HTTP/TCP.Change Type
How did you test this PR?
Ensured the
run-ground-truthCI step ran correctly for this PR's CI pipeline.References
N/A