Disable Ruby 2.7-3.3 for multicontainer #5834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
lloeki
force-pushed
the
lloeki/scale-down-ruby-multi-container
branch
from
9ea4ee7 to
b7ba1a6
Compare
Member
Author
|
Failed with: This is absurdly unclear, but that is apparently caused by the nginx reply contents that I commented out, but one can't comment in there. Note, when attempting to reproduce "locally" (i.e drive the VM creation locally), it stops earlier and I get this instead: |
lloeki
force-pushed
the
lloeki/scale-down-ruby-multi-container
branch
from
b7ba1a6 to
1764b84
Compare
| healthcheck: | ||
| test: "curl -f http://localhost:8080" | ||
|
|
||
| ruby_3_4: |
Collaborator
There was a problem hiding this comment.
I think this is where the problem lies. In the nginx configuration, we are maintaining version 3.4.
Member
Author
There was a problem hiding this comment.
Damn, I swear I looked at that diff a dozen times over before pushing.
Member
Author
There was a problem hiding this comment.
There was another one, missing a } in nginx.conf:
location /ruby_3_4/ {
proxy_pass http://ruby_3_4_app/;
proxy_redirect off;
location /ruby_2_6/ {
proxy_pass http://ruby_2_6_app/;
proxy_redirect off;
}
1efe899 to
fb8730f
Compare
This is a mitigation for crossing the 1h timeout. These versions should be extracted to single container cases, while multicontainer should test an actually interesting multicontainer. Meanwhile, we keep the min and max.
lloeki
force-pushed
the
lloeki/scale-down-ruby-multi-container
branch
from
fb8730f to
79df244
Compare
robertomonteromiguel
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a mitigation for crossing the 1h timeout.
These versions should be extracted to single container cases, while multicontainer should test an actually interesting multicontainer.
Changes
We keep the min and max,
but comment out bits and keep dead Dockerfiles for them to be moved sooner rather than later.EDIT: Removed those as well as commenting out is not an option because JSON.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present