fix fail to catch last backslash # 780 #782
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static cJSON_bool parse_string(cJSON * const item, parse_buffer * const input_buffer)
{
...
// this does not work
if ((size_t)(input_end + 1 - input_buffer->content) >= input_buffer->length)
{
/* prevent buffer overflow when last input character is a backslash */
goto fail;
}
...
}
As show above , when last input character is a backslash.The index of input_end is always input_buffer->length - 2.
So input_end + 1 - input_buffer->content >= input_buffer->length will never come true。
Maybe we should minus 1 in the right:
input_end + 1 - input_buffer->content >= input_buffer->length-1