Skip to content

Fix error location reporting for required files in LP console - #1499

Merged
fblanqui merged 10 commits into
Deducteam:masterfrom
Alidra:fix-position
Sep 8, 2026
Merged

fblanqui merged 10 commits into
Deducteam:masterfrom
Alidra:fix-position

Conversation

@Alidra

@Alidra Alidra commented Sep 1, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR fixes :
-1 The location is displayed in the LP console when a syntax error occurs (issue #1456)
-2 Errors are displayed in Red color and location is put between bracket (issue #1405)
-3 When an LP file requires another file and the error originates in the required file, the location of the require open command is used so that when the "requiring" file is executed the error is displayed in the terminal when the user reaches the require command (issue #1498)

Changes

  • keep the precise from the originating error when an error is reported from a required module
  • prefer the real error location when it points to a different file than the current command
  • add a space separator between the file location and the message in the console output
  • ensure logs include the position in a readable format for debugging and traceability

@fblanqui fblanqui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.

Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml Outdated
Comment thread src/lsp/lp_doc.ml
Comment thread src/lsp/lp_doc.ml Outdated
@fblanqui
fblanqui merged commit 47f2080 into Deducteam:master Sep 8, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants