Skip to content

Conversation

valentijnscholten
Copy link
Member

@valentijnscholten valentijnscholten commented Sep 2, 2025

I wasn't going to spend time on this, but then Cursor AI got it right almost on the first go.

Some dependencies are only needed for development, we shouldn't install those in the release ("production") images.

@github-actions github-actions bot added docker settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs labels Sep 2, 2025
@valentijnscholten valentijnscholten changed the base branch from bugfix to dev September 2, 2025 17:54
@github-actions github-actions bot removed settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs labels Sep 2, 2025
@valentijnscholten valentijnscholten marked this pull request as ready for review September 2, 2025 17:55
@valentijnscholten valentijnscholten modified the milestones: 2.51.1, 2.51.0 Sep 2, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro
Copy link
Contributor

mtesauro commented Sep 2, 2025

Did you consider doing the same for for the Debian dockerfile?
https://github.com/DefectDojo/django-DefectDojo/blob/master/Dockerfile.django-debian

@valentijnscholten
Copy link
Member Author

Did you consider doing the same for for the Debian dockerfile? https://github.com/DefectDojo/django-DefectDojo/blob/master/Dockerfile.django-debian

Yes, it's part of the PR or did I miss a part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants