Skip to content

fix(helm): Empty string values propagated as strings (not as null) #13200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maffooch merged 1 commit into from
Sep 19, 2025
Merged

fix(helm): Empty string values propagated as strings (not as null) #13200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions helm/defectdojo/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,13 +516,13 @@ A Helm chart for Kubernetes to install DefectDojo

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| admin.credentialAes256Key | string | `nil` | |
| admin.credentialAes256Key | string | `""` | |
| admin.firstName | string | `"Administrator"` | |
| admin.lastName | string | `"User"` | |
| admin.mail | string | `"[email protected]"` | |
| admin.metricsHttpAuthPassword | string | `nil` | |
| admin.password | string | `nil` | |
| admin.secretKey | string | `nil` | |
| admin.metricsHttpAuthPassword | string | `""` | |
| admin.password | string | `""` | |
| admin.secretKey | string | `""` | |
| admin.user | string | `"admin"` | |
| annotations | object | `{}` | |
| celery.annotations | object | `{}` | |
Expand Down Expand Up @@ -594,9 +594,9 @@ A Helm chart for Kubernetes to install DefectDojo
| django.mediaPersistentVolume.name | string | `"media"` | |
| django.mediaPersistentVolume.persistentVolumeClaim.accessModes[0] | string | `"ReadWriteMany"` | |
| django.mediaPersistentVolume.persistentVolumeClaim.create | bool | `false` | |
| django.mediaPersistentVolume.persistentVolumeClaim.name | string | `nil` | |
| django.mediaPersistentVolume.persistentVolumeClaim.name | string | `""` | |
| django.mediaPersistentVolume.persistentVolumeClaim.size | string | `"5Gi"` | |
| django.mediaPersistentVolume.persistentVolumeClaim.storageClassName | string | `nil` | |
| django.mediaPersistentVolume.persistentVolumeClaim.storageClassName | string | `""` | |
| django.mediaPersistentVolume.type | string | `"emptyDir"` | |
| django.nginx.extraEnv | list | `[]` | |
| django.nginx.extraVolumeMounts | list | `[]` | |
Expand Down
12 changes: 6 additions & 6 deletions helm/defectdojo/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"type": "object",
"properties": {
"credentialAes256Key": {
"type": "null"
"type": "string"
},
"firstName": {
"type": "string"
Expand All @@ -18,13 +18,13 @@
"type": "string"
},
"metricsHttpAuthPassword": {
"type": "null"
"type": "string"
},
"password": {
"type": "null"
"type": "string"
},
"secretKey": {
"type": "null"
"type": "string"
},
"user": {
"type": "string"
Expand Down Expand Up @@ -339,13 +339,13 @@
"type": "boolean"
},
"name": {
"type": "null"
"type": "string"
},
"size": {
"type": "string"
},
"storageClassName": {
"type": "null"
"type": "string"
}
}
},
Expand Down
12 changes: 6 additions & 6 deletions helm/defectdojo/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,13 @@ tests:

admin:
user: admin
password:
password: ""
firstName: Administrator
lastName: User
mail: [email protected]
secretKey:
credentialAes256Key:
metricsHttpAuthPassword:
secretKey: ""
credentialAes256Key: ""
metricsHttpAuthPassword: ""

monitoring:
enabled: false
Expand Down Expand Up @@ -356,11 +356,11 @@ django:
persistentVolumeClaim:
# set to true to create a new pvc and if django.mediaPersistentVolume.type is set to pvc
create: false
name:
name: ""
size: 5Gi
accessModes:
- ReadWriteMany # check KUBERNETES.md doc first for option to choose
storageClassName:
storageClassName: ""

initializer:
run: true
Expand Down