-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Unit Tests: Ignore deprecation Warning from BlackDuck pypi package #13225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mtesauro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
valentijnscholten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes #13218
|
Last 2 days I've been repushing same PRs as it would pass sometimes 😆 , thanks! But is it ok to suppress deprecation warnings entirely (for whole dojo)? Or should it be changed to suppress only these calls? |
|
Oh, I didn't realize that is how the warning system worked. Would this work? with warnings.catch_warnings(action="ignore", category=DeprecationWarning):
from blackduck import Client # noqa: E402 |
Correcting an incorrect scope assignment of the warnings class #13225 (comment)
* Refactor warning handling for blackduck import Correcting an incorrect scope assignment of the warnings class #13225 (comment) * Update dojo/tools/api_blackduck/api_client.py * Update dojo/tools/api_blackduck/api_client.py
Unit tests are failing due to a deprecation warning in the black duck pypi package. The library does not appear to be very active these days, so ignoring the warning feels like the quickest path to getting our tests back on track