Skip to content

Conversation

@Maffooch
Copy link
Contributor

Unit tests are failing due to a deprecation warning in the black duck pypi package. The library does not appear to be very active these days, so ignoring the warning feels like the quickest path to getting our tests back on track

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Member

@valentijnscholten valentijnscholten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #13218

@valentijnscholten valentijnscholten merged commit f5d8ea5 into dev Sep 19, 2025
154 of 156 checks passed
@Maffooch Maffooch deleted the unit-test-patch branch September 19, 2025 18:33
@fopina
Copy link
Contributor

fopina commented Sep 19, 2025

Last 2 days I've been repushing same PRs as it would pass sometimes 😆 , thanks!

But is it ok to suppress deprecation warnings entirely (for whole dojo)? Or should it be changed to suppress only these calls?

@Maffooch
Copy link
Contributor Author

Oh, I didn't realize that is how the warning system worked. Would this work?

with warnings.catch_warnings(action="ignore", category=DeprecationWarning):
    from blackduck import Client  # noqa: E402

Maffooch added a commit that referenced this pull request Sep 19, 2025
Correcting an incorrect scope assignment of the warnings class

#13225 (comment)
@valentijnscholten valentijnscholten added this to the 2.51.0 milestone Sep 20, 2025
valentijnscholten pushed a commit that referenced this pull request Sep 24, 2025
* Refactor warning handling for blackduck import

Correcting an incorrect scope assignment of the warnings class

#13225 (comment)

* Update dojo/tools/api_blackduck/api_client.py

* Update dojo/tools/api_blackduck/api_client.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants