Skip to content

fix(helm): Fix PVC templating after #13210 #13619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
valentijnscholten merged 3 commits into from
Nov 7, 2025
Merged

fix(helm): Fix PVC templating after #13210 #13619

valentijnscholten merged 3 commits into from
Nov 7, 2025

Conversation

@kiblik
Copy link
Contributor

@kiblik kiblik commented Nov 4, 2025

After #13210, charts with enabled PVC were complaining

executing "defectdojo/templates/media-pvc.yaml" at <.Values.extraAnnotations>: nil pointer evaluating interface {}.extraAnnotations

JFIY @fernandezcuesta, we missed some details. I hope this is the only missed detail.
More complex tests of HELM charts would be useful.

@github-actions github-actions bot added the helm label Nov 4, 2025
@fernandezcuesta
Copy link
Contributor

fernandezcuesta commented Nov 4, 2025

Oops my bad, sorry for that. I'm more convinced to always use $ regardless of whether inside a with statement or not....

@kiblik
Copy link
Contributor Author

kiblik commented Nov 4, 2025

Oops my bad, sorry for that. I'm more convinced to always use $ regardless of whether inside a with statement or not....

If we would perform another "large rewrite", I would probably go with $ everywhere. But for now, this fix is enough in my opinion.

mtesauro
mtesauro approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten valentijnscholten added this to the 2.52.1 milestone Nov 5, 2025
@kiblik
Copy link
Contributor Author

kiblik commented Nov 6, 2025

Based on #13620 (comment), I merged changes into this PR.
There is no other HELM-related PR that would have this kind of easy fix. Others need more time for review.

This was referenced Nov 6, 2025
Closed
Closed
@valentijnscholten valentijnscholten linked an issue Nov 6, 2025 that may be closed by this pull request
Helm media-pvc nil pointer in 2.52.0 #13640
Closed
3 tasks
@Maffooch Maffooch requested a review from Jino-T November 7, 2025 16:44
@milosveljkovic milosveljkovic mentioned this pull request Nov 7, 2025
Closed
@Maffooch Maffooch requested a review from blakeaowens November 7, 2025 21:47
@valentijnscholten valentijnscholten merged commit e2dbca5 into DefectDojo:bugfix Nov 7, 2025
150 checks passed
@kiblik kiblik deleted the helm_fix_pvc branch November 7, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtesauro mtesauro mtesauro approved these changes

@valentijnscholten valentijnscholten valentijnscholten approved these changes

@Maffooch Maffooch Maffooch approved these changes

@blakeaowens blakeaowens blakeaowens approved these changes

@rossops rossops Awaiting requested review from rossops

@Jino-T Jino-T Awaiting requested review from Jino-T

Assignees

No one assigned

Labels

helm

Projects

None yet

Milestone

2.52.1

Development

Successfully merging this pull request may close these issues.

Helm media-pvc nil pointer in 2.52.0

6 participants

@kiblik @fernandezcuesta @mtesauro @valentijnscholten @Maffooch @blakeaowens