-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add Frankencoin protocol revenue adapter #3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samclassix
wants to merge
1
commit into
DefiLlama:master
Choose a base branch
from
Frankencoin-ZCHF:frankencoin-earnings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
import { FetchOptions, SimpleAdapter } from "../../adapters/types"; | ||
import { CHAIN } from "../../helpers/chains"; | ||
import { request, gql } from "graphql-request"; | ||
|
||
// GraphQL endpoint for Frankencoin | ||
const FRANKENCOIN_GRAPH_URL = "https://ponder.test.frankencoin.com"; // TODO: change to production URL | ||
|
||
// ZCHF token address on Ethereum | ||
const ZCHF_ADDRESS = "0xB58E61C3098d85632Df34EecfB899A1Ed80921cB"; | ||
|
||
const PROFIT_LOSS_QUERY = gql` | ||
query GetProfitLoss { | ||
frankencoinProfitLosss( | ||
orderBy: "count", | ||
orderDirection: "desc", | ||
limit: 1, | ||
) { | ||
items { | ||
profits | ||
losses | ||
} | ||
} | ||
} | ||
`; | ||
|
||
const fetch = async (options: FetchOptions) => { | ||
const dailyFees = options.createBalances(); | ||
const dailyRevenue = options.createBalances(); | ||
|
||
try { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please remove try-catch as we have to let the adapter fail in case any errors, so we can fix the issue |
||
const { frankencoinProfitLosss } = await request(FRANKENCOIN_GRAPH_URL, PROFIT_LOSS_QUERY); | ||
|
||
const profits = frankencoinProfitLosss?.items?.[0]?.profits ?? "0"; | ||
const losses = frankencoinProfitLosss?.items?.[0]?.losses ?? "0"; | ||
|
||
// Convert string values to BigInt for calculations | ||
const profitsBigInt = BigInt(profits); | ||
const lossesBigInt = BigInt(losses); | ||
|
||
// Fees are the total profits in ZCHF | ||
dailyFees.add(ZCHF_ADDRESS, profitsBigInt); | ||
|
||
// Revenue is profits minus losses in ZCHF | ||
const revenue = profitsBigInt - lossesBigInt; | ||
dailyRevenue.add(ZCHF_ADDRESS, revenue); | ||
|
||
return { | ||
dailyFees, | ||
dailyRevenue, | ||
dailyProtocolRevenue: dailyRevenue, | ||
}; | ||
} catch (error) { | ||
console.error("Error fetching Frankencoin data:", error); | ||
return { | ||
dailyFees, | ||
dailyRevenue, | ||
dailyProtocolRevenue: dailyRevenue, | ||
}; | ||
} | ||
}; | ||
|
||
const adapter: SimpleAdapter = { | ||
version: 2, | ||
adapter: { | ||
[CHAIN.ETHEREUM]: { | ||
fetch, | ||
start: '2023-10-28', | ||
meta: { | ||
methodology: { | ||
Fees: "Total profits generated by the Frankencoin protocol in ZCHF tokens", | ||
Revenue: "Net revenue calculated as profits minus losses in ZCHF tokens", | ||
ProtocolRevenue: "All net revenue is retained by the protocol in ZCHF tokens", | ||
} | ||
} | ||
} | ||
} | ||
}; | ||
|
||
export default adapter; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need more information regarding the how profit/loss are calculated? as daily ~1M revenue for 30m TVL looks very high, so please provide more information, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoi
the graph table is just an entry of all profits and losses. And therefore its the accumulated profits/losses of all times. I thought the defillama api is regularly fetching the numbers and calculate the difference between the fetches and therefore knows how much the daily values would be.
maybe i have to refactor this.
So you need explicitly the daily p/l?
How does the fetcher function know which date it is?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samclassix you can read more about how dimension adapter works here(https://docs.llama.fi/list-your-project/other-dashboards)
but i will give you tldr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand how all profit goes to protocol, isn't there any yield for token holders?