add Priority Trade fees/volume adapter (MegaETH)#6395
Open
thomasxpx wants to merge 1 commit intoDefiLlama:masterfrom
Open
add Priority Trade fees/volume adapter (MegaETH)#6395thomasxpx wants to merge 1 commit intoDefiLlama:masterfrom
thomasxpx wants to merge 1 commit intoDefiLlama:masterfrom
Conversation
Contributor
Summary by CodeRabbit
WalkthroughAdded a new adapter module for computing daily ETH trading volume and trading fees for the MEGAETH Priority Trade flow. The adapter performs timestamp-to-block conversion via binary search, fetches router event logs, ABI-decodes buy/sell events, and aggregates trading volume and fee metrics. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The priority-trade adapter exports: |
bheluga
requested changes
Apr 14, 2026
Member
bheluga
left a comment
bheluga
left a comment
There was a problem hiding this comment.
@thomasxpx thanks for the PR.
We have getLogs helper function , so you need not write so much code to get event logs. You can refer https://github.com/DefiLlama/dimension-adapters/blob/master/aggregators/liquidswap/index.ts for example.
Also try to use eventAbi instead of topic, its easy to read and doesnt need to be decoded
Contributor
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@fees/priority-trade/index.ts`:
- Around line 25-36: The custom binary-search helper getBlockAtTimestamp is
redundant and should be removed; update fetch_ to call
FetchOptions.getFromBlock(timestamp) and FetchOptions.getToBlock(timestamp) (or
the appropriate getFromBlock()/getToBlock() overloads on the provided
FetchOptions instance) instead of invoking getBlockAtTimestamp and performing
RPCs directly, ensuring you rely on the framework’s caching/optimizations and
handle any returned block numbers/Promised values the same way fetch_ used the
result from getBlockAtTimestamp.
- Around line 38-59: The code is calling rpc/getBlockAtTimestamp via a custom
fetchLogs function inside fetch_ instead of using the framework's
FetchOptions.getLogs; replace the custom log fetching by removing fetchLogs, rpc
and getBlockAtTimestamp usage and call options.getLogs(...) to fetch logs for
ROUTER with topics TOPIC_BUY and TOPIC_SELL (use
options.startTimestamp/options.endTimestamp or their block equivalents per
getLogs API), then parse the returned logs into buyRaw/sellRaw and continue
using dailyFees/dailyVolume as before; update references to fetchLogs, rpc, and
getBlockAtTimestamp so only options.getLogs and fetch_ remain.
- Around line 93-112: The breakdownMethodology uses a non-existent key
METRIC.SPOT_TRADING_VOLUME; fix by checking the METRIC enum and either add
SPOT_TRADING_VOLUME to the enum or replace METRIC.SPOT_TRADING_VOLUME with the
correct existing metric constant used elsewhere (e.g., the project’s canonical
volume metric), and update the description accordingly in breakdownMethodology;
also verify the adapter object matches the SimpleAdapter type (confirm whether
fetch should be named fetch or fetch_ and whether chains should be an array or a
single CHAIN value) and adjust the adapter properties (adapter.version,
adapter.fetch, adapter.chains, adapter.start, adapter.methodology,
adapter.breakdownMethodology) to the expected shape.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b3aa5b8a-e82f-49c4-a77d-7e1f560f640d
📒 Files selected for processing (1)
fees/priority-trade/index.ts
Comment on lines
+25
to
+36
| async function getBlockAtTimestamp(timestamp: number): Promise<number> { | ||
| const latestHex: string = await rpc("eth_blockNumber", []); | ||
| let lo = 0, hi = parseInt(latestHex, 16); | ||
|
|
||
| while (lo < hi) { | ||
| const mid = Math.floor((lo + hi) / 2); | ||
| const block: any = await rpc("eth_getBlockByNumber", ["0x" + mid.toString(16), false]); | ||
| const ts = parseInt(block.timestamp, 16); | ||
| if (ts < timestamp) lo = mid + 1; else hi = mid; | ||
| } | ||
| return lo; | ||
| } |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Use FetchOptions.getFromBlock() and getToBlock() instead of custom binary search.
The FetchOptions object already provides getFromBlock() and getToBlock() methods that handle timestamp-to-block conversion. This custom binary search:
- Makes O(log n) RPC calls unnecessarily
- Bypasses framework's caching and optimizations
- May fail on chains with irregular block times (edge cases not handled)
Proposed fix
- async function getBlockAtTimestamp(timestamp: number): Promise<number> {
- const latestHex: string = await rpc("eth_blockNumber", []);
- let lo = 0, hi = parseInt(latestHex, 16);
-
- while (lo < hi) {
- const mid = Math.floor((lo + hi) / 2);
- const block: any = await rpc("eth_getBlockByNumber", ["0x" + mid.toString(16), false]);
- const ts = parseInt(block.timestamp, 16);
- if (ts < timestamp) lo = mid + 1; else hi = mid;
- }
- return lo;
- }Then in fetch_:
- const [fromBlock, toBlock] = await Promise.all([
- getBlockAtTimestamp(options.startTimestamp),
- getBlockAtTimestamp(options.endTimestamp),
- ]);
+ const [fromBlock, toBlock] = await Promise.all([
+ options.getFromBlock(),
+ options.getToBlock(),
+ ]);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@fees/priority-trade/index.ts` around lines 25 - 36, The custom binary-search
helper getBlockAtTimestamp is redundant and should be removed; update fetch_ to
call FetchOptions.getFromBlock(timestamp) and FetchOptions.getToBlock(timestamp)
(or the appropriate getFromBlock()/getToBlock() overloads on the provided
FetchOptions instance) instead of invoking getBlockAtTimestamp and performing
RPCs directly, ensuring you rely on the framework’s caching/optimizations and
handle any returned block numbers/Promised values the same way fetch_ used the
result from getBlockAtTimestamp.
Comment on lines
+38
to
+59
| async function fetchLogs(fromBlock: number, toBlock: number, topic: string): Promise<any[]> { | ||
| return rpc("eth_getLogs", [{ | ||
| address: ROUTER, | ||
| fromBlock: "0x" + fromBlock.toString(16), | ||
| toBlock: "0x" + toBlock.toString(16), | ||
| topics: [topic], | ||
| }]); | ||
| } | ||
|
|
||
| const fetch_ = async (options: FetchOptions) => { | ||
| const dailyFees = options.createBalances(); | ||
| const dailyVolume = options.createBalances(); | ||
|
|
||
| const [fromBlock, toBlock] = await Promise.all([ | ||
| getBlockAtTimestamp(options.startTimestamp), | ||
| getBlockAtTimestamp(options.endTimestamp), | ||
| ]); | ||
|
|
||
| const [buyRaw, sellRaw] = await Promise.all([ | ||
| fetchLogs(fromBlock, toBlock, TOPIC_BUY), | ||
| fetchLogs(fromBlock, toBlock, TOPIC_SELL), | ||
| ]); |
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Use options.getLogs() instead of custom RPC log fetching.
The FetchOptions object provides a getLogs() method that should be used instead of direct RPC calls. This ensures consistency with the framework and benefits from built-in optimizations.
Proposed fix using options.getLogs()
- async function fetchLogs(fromBlock: number, toBlock: number, topic: string): Promise<any[]> {
- return rpc("eth_getLogs", [{
- address: ROUTER,
- fromBlock: "0x" + fromBlock.toString(16),
- toBlock: "0x" + toBlock.toString(16),
- topics: [topic],
- }]);
- }
// In fetch_:
- const [buyRaw, sellRaw] = await Promise.all([
- fetchLogs(fromBlock, toBlock, TOPIC_BUY),
- fetchLogs(fromBlock, toBlock, TOPIC_SELL),
- ]);
+ const [buyRaw, sellRaw] = await Promise.all([
+ options.getLogs({ target: ROUTER, topics: [TOPIC_BUY] }),
+ options.getLogs({ target: ROUTER, topics: [TOPIC_SELL] }),
+ ]);This eliminates the need for custom rpc(), fetchLogs(), and getBlockAtTimestamp() functions entirely.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@fees/priority-trade/index.ts` around lines 38 - 59, The code is calling
rpc/getBlockAtTimestamp via a custom fetchLogs function inside fetch_ instead of
using the framework's FetchOptions.getLogs; replace the custom log fetching by
removing fetchLogs, rpc and getBlockAtTimestamp usage and call
options.getLogs(...) to fetch logs for ROUTER with topics TOPIC_BUY and
TOPIC_SELL (use options.startTimestamp/options.endTimestamp or their block
equivalents per getLogs API), then parse the returned logs into buyRaw/sellRaw
and continue using dailyFees/dailyVolume as before; update references to
fetchLogs, rpc, and getBlockAtTimestamp so only options.getLogs and fetch_
remain.
Comment on lines
+93
to
+112
| const breakdownMethodology = { | ||
| Volume: { | ||
| [METRIC.SPOT_TRADING_VOLUME]: "ETH volume from token buys and sells executed via the Priority Trade Telegram bot.", | ||
| }, | ||
| Fees: { | ||
| [METRIC.TRADING_FEES]: "1% trading fee charged on each swap executed through Priority Trade.", | ||
| }, | ||
| Revenue: { | ||
| [METRIC.TRADING_FEES]: "Trading fees collected by the Priority Trade protocol.", | ||
| }, | ||
| }; | ||
|
|
||
| const adapter: SimpleAdapter = { | ||
| version: 2, | ||
| fetch: fetch_, | ||
| chains: [CHAIN.MEGAETH], | ||
| start: "2026-02-04", | ||
| methodology, | ||
| breakdownMethodology, | ||
| }; |
Contributor
There was a problem hiding this comment.
breakdownMethodology references non-existent METRIC.SPOT_TRADING_VOLUME.
The breakdownMethodology object uses METRIC.SPOT_TRADING_VOLUME as a key, which doesn't exist in the METRIC enum. This will either fail at compile time or result in undefined as the key.
Additionally, the adapter structure uses fetch and chains at the top level. Verify this matches the expected SimpleAdapter structure for single-chain adapters.
Proposed fix aligned with METRIC enum changes
If adding SPOT_TRADING_VOLUME to the METRIC enum:
// No changes needed to breakdownMethodologyIf removing metric labels for volume:
const breakdownMethodology = {
- Volume: {
- [METRIC.SPOT_TRADING_VOLUME]: "ETH volume from token buys and sells executed via the Priority Trade Telegram bot.",
- },
+ Volume: "ETH volume from token buys and sells executed via the Priority Trade Telegram bot.",
Fees: {
[METRIC.TRADING_FEES]: "1% trading fee charged on each swap executed through Priority Trade.",
},🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@fees/priority-trade/index.ts` around lines 93 - 112, The breakdownMethodology
uses a non-existent key METRIC.SPOT_TRADING_VOLUME; fix by checking the METRIC
enum and either add SPOT_TRADING_VOLUME to the enum or replace
METRIC.SPOT_TRADING_VOLUME with the correct existing metric constant used
elsewhere (e.g., the project’s canonical volume metric), and update the
description accordingly in breakdownMethodology; also verify the adapter object
matches the SimpleAdapter type (confirm whether fetch should be named fetch or
fetch_ and whether chains should be an array or a single CHAIN value) and adjust
the adapter properties (adapter.version, adapter.fetch, adapter.chains,
adapter.start, adapter.methodology, adapter.breakdownMethodology) to the
expected shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name (to be shown on DefiLlama):
Priority
Twitter Link:
https://x.com/PriorityTrade_
List of audit links if any:
Website Link:
https://t.me/prioritytradebot
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury) :
0xaA8995eA9d805089aCF102A2a80Dc92CA7a5c9fB
Chain:
MegaETH
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
The fastest Telegram trading bot designed for MegaETH.
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Telegram Bot
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
https://docs.prioritytrade.xyz/
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):
Does this project have a referral program?
yes