Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start indices #285

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Start indices #285

wants to merge 2 commits into from

Conversation

amoodie
Copy link
Member

@amoodie amoodie commented Mar 10, 2025

Relocates initialization of start indices from get_inlet_weights_water to init_water_iteration methods, allowing the weights and start indices to be modified by existing hooking approaches. No change to default functionality.

@amoodie amoodie added the enhancement New feature or request label Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.40%. Comparing base (17c2e67) to head (01389ac).
Report is 27 commits behind head on develop.

Files with missing lines Patch % Lines
pyDeltaRCM/water_tools.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #285      +/-   ##
===========================================
- Coverage    78.92%   78.40%   -0.53%     
===========================================
  Files           12       12              
  Lines         2634     2635       +1     
===========================================
- Hits          2079     2066      -13     
- Misses         555      569      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant