Merged
Conversation
8469cfa to
3e490fb
Compare
Contributor
Author
|
Per discussion on slack, I've removed This PR has also been deployed to https://stage.electionleaflets.org/ |
chris48s
reviewed
Oct 21, 2025
| from leaflets.models import Leaflet, LeafletImage | ||
| from leaflets.tests.conftest import TEST_IMAGE_LOCATION | ||
|
|
||
| TEST_STORAGES = settings.STORAGES.copy() |
Member
There was a problem hiding this comment.
Question: Do we need to deepcopy() here?
Member
|
Its annoying that django-s3file isn't on PyPI but having looked over codingjoe/django-s3file@5.5.7...6.0.0 I don't think there is anything we need in it for django 5.2 compatibility so I reckon lets just stick on 5.5.7 rather than switch to a VCS dependency. I raised an issue upstream about it anyway. |
c2d4021 to
bc08192
Compare
chris48s
approved these changes
Oct 22, 2025
Member
|
will leave it with you to:
and merge |
bc08192 to
4e5f138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to django
5.2.7. Also bumps the following packages:Notes:
django-braceslatest release doesn't officially support django>4.2.It looks like there is a "spiritual successor" called django-brackets that is for django>4.2and does the same things. However, for the stuff we're using fromdjango-braces(LoginRequiredMixin,StaffuserRequiredMixin) doesn't seem broken , so not sure if it's worth switching from braces to brackets?django-formtoolsbump that caused issues outlined in upgrade django-formtools==2.5.1 (attempt 2) EveryElection#2537 doesn't seem to break anything on this repo. I'm not sure why and worried I'm missing something so it would be good to double check this assumption.django-s3filehas a 6.0.0 release on github that supports django5.1, but its not on PyPi for some reason.django-debug-toolbarwasn't actually set up properly so I did that.Deprecations:
dc-django-utilsand replaced STATICFILES_STORAGE with the STORAGES dict. We weren't importing the default pipeline settings from dc_utils in this repo so I also implemented that.dc-design-systemto the latest version but didn't need to update anything.django-querystring-tagbecause its part of core django now.