Skip to content

Conversation

@samsmith
Copy link
Contributor

@samsmith samsmith commented Apr 8, 2022

if there's a comma in the name at the end, then it is still "surname, firstname" and the bot should be able to fix that

needs more testing

if there's a comma in the name at the end, then it is still "surname, firstname" and the bot should be able to fix that
@michaeljcollinsuk
Copy link
Contributor

if there's a comma in the name at the end, then it is still "surname, firstname" and the bot should be able to fix that

needs more testing

This is a good idea, but unfortunately I dont think it will work as is because at the point that the clean_name method is called, all text for the row will have been run through the clean_text method which strips out commas . So we might need to think about reworking the order of the cleaning somehow.

@samsmith
Copy link
Contributor Author

while you're theoretically right, there were surname comma firstname lines in bot parsed SOPNs on candidates.democlub last week so something didn't work as it should.

@michaeljcollinsuk
Copy link
Contributor

Oh I see, interesting. Do you happen to remember any of the ballots that were affected?

@samsmith
Copy link
Contributor Author

I think this one was, but the DB will know https://candidates.democracyclub.org.uk/elections/local.somerset.south-petherton-and-islemoor.2022-05-05/sopn/

@symroe symroe force-pushed the master branch 2 times, most recently from 64904b0 to 44bf9f8 Compare April 8, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants