Prep PPCS importer for GE #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirginiaDooley
force-pushed
the
hotfix/import-next-ppcs
branch
from
db3e3cc to
a0d7d70
Compare
VirginiaDooley
force-pushed
the
hotfix/import-next-ppcs
branch
2 times, most recently
from
c745a34 to
a0d7d70
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
symroe
approved these changes
Jan 26, 2024
Member
symroe
left a comment
symroe
left a comment
There was a problem hiding this comment.
Based on our live testing yesterday I think this is good to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://app.asana.com/0/1206157967511125/1206157968203036/f
Currently
python manage.py candidatebot_import_next_ppcs --sheet-url SHEET_URLthrows the expected error when run without existing elections:ValueError: No future parl election found!Using #1998, I created a dummy parliamentary election to test the importer. We do not have accurate ballot IDs so I've used the same for all just for testing purposes.
The changes that need to made to the importer include:
Additional changes that need to be made to the sheet as well as next steps are recorded here.