Skip to content

Hotfix/fix for failures #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VirginiaDooley merged 3 commits into from
Jan 15, 2024
Merged

Hotfix/fix for failures #2213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdeea85
Remove deprecated loggin_panel for debug_toolbar
VirginiaDooley Jan 15, 2024
2d48aa8
USE_L1ON is deprecated; now built in
VirginiaDooley Jan 15, 2024
4c24fc4
The 'text' argument to find()-type methods is deprecated
VirginiaDooley Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ynr/apps/elections/tests/test_election_list_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def test_single_election_posts_page(self):

self.assertTrue(
response.html.find(
"a", text="Member of Parliament for Camberwell and Peckham"
"a", string="Member of Parliament for Camberwell and Peckham"
)
)

Expand Down
2 changes: 1 addition & 1 deletion ynr/apps/elections/tests/test_elections_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ def test_constituencies_page(self):
# Just a smoke test to check that the page loads:
response = self.app.get("/elections/parl.2015-05-07/")
dulwich = response.html.find(
"a", text=re.compile(r"Dulwich and West Norwood")
"a", string=re.compile(r"Dulwich and West Norwood")
)
self.assertTrue(dulwich)
4 changes: 2 additions & 2 deletions ynr/apps/elections/uk/tests/test_finders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def test_nonsense_postcode_searches_for_candidate(self, mock_requests):
self.assertEqual(response.status_code, 200)
self.assertIn("Search candidates", response)
a = response.html.find(
"a", text=re.compile('Add "foo bar" as a new candidate')
"a", string=re.compile('Add "foo bar" as a new candidate')
)
self.assertEqual(
a["href"], "/person/create/select_election?name=foo bar"
Expand All @@ -211,7 +211,7 @@ def test_nonascii_postcode(self, mock_requests):
self.assertEqual(response.status_code, 200)
self.assertIn("Search candidates", response)
a = response.html.find(
"a", text=re.compile('Add "SW1A 1ӔA" as a new candidate')
"a", string=re.compile('Add "SW1A 1ӔA" as a new candidate')
)
self.assertEqual(
a["href"], "/person/create/select_election?name=SW1A 1\u04d4A"
Expand Down
2 changes: 0 additions & 2 deletions ynr/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ def root(*path):
"debug_toolbar.panels.templates.TemplatesPanel",
"debug_toolbar.panels.cache.CachePanel",
"debug_toolbar.panels.signals.SignalsPanel",
"debug_toolbar.panels.logging.LoggingPanel",
"debug_toolbar.panels.redirects.RedirectsPanel",
]
INTERNAL_IPS = ["127.0.0.1"]
Expand All @@ -225,7 +224,6 @@ def root(*path):
LANGUAGE_CODE = "en-gb"
TIME_ZONE = "Europe/London"
USE_I18N = False
USE_L10N = True
USE_TZ = True
DD_MM_DATE_FORMAT_PREFERRED = True

Expand Down