work out biography_last_updated from version history #2630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
commented
Nov 26, 2025
chris48s
changed the title
chris48s
force-pushed
the
boi-last-update20251126
branch
from
bc24909 to
8587034
Compare
Member
Author
|
I've updated this to use the approach suggested. |
Member
|
I sill have some concerns about performance of generating this on the fly, but I can't actually cause any problems on my local install. Pushing more work to the DB at least means it'll be easy enough to track if this were a problem, so I think we should run with it for now and keep an eye on things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://app.asana.com/1/1204880536137786/project/1204880927741389/task/1212070426872673?focus=true
In this PR, I am getting rid of
biography_last_updatedas a field we explicitly set. I've converted it to a property which is inferred from the version history. It is still surfaced as a field in the API for WCIVF to consume.