Open
Conversation
This is confusing for new users, and the 'unlocked' icon is very unclear
It's not useful to ask users to add a single canddiate when we have a SOPN
Member
Author
|
Closes #756 |
chris48s
reviewed
Feb 23, 2026
Move the election to the heading and make everything smaller apart from the ballot name
symroe
force-pushed
the
sopn-indication
branch
3 times, most recently
from
095bec5 to
a23c466
Compare
symroe
force-pushed
the
sopn-indication
branch
from
a23c466 to
5eee762
Compare
Combine a bunch of logic and move everything to the top of the page in a status block.
symroe
force-pushed
the
sopn-indication
branch
2 times, most recently
from
3787333 to
5e61f50
Compare
This is especially needed when there are no candidates on the ballot
Member
Author
|
One thing to note is that the template indenting is all over the place. I've had to disable my editor's indenting as it's going to change everything. Once this PR is in I'd like to shove djhtml in this project to keep it in line with other projects and do a big reformattting commit. Let's ignore indending for the time being. |
I think this is a nicer way to link 'candidate actions' with the candidate table, leaving other actions to be 'ballot actions' in a fucutre commit.
In CI we fail if ruff format fails, but we don't fail pytest. This means local devs need to remember to run format before pushing. This change means that pytest will fail if ruff format would make changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bucket'o'changes that all focus on some easy wins in the UI.
Some of them are in direct response to feedback we've got, some of them are things I noticed while working on the project. I'll try to break them out.
Icons
There are some areas where we use icons to indicate something. This is generally useful for power users (as most users are), but less useful for new users. We've moved to using both icon and text where we can.
Still TODO:
SOPN upload indication
Fixed a minor bug on the all elections page that didn't show if a SOPN was uploaded to a ballot.
This is written as "At present it’s not obvious whether a ballot has a SoPN or not" and is addressed in f9b4a1c.
Add candidates button on ballot page
I've made a number of changes here.
For anonymous users I've hidden the 'add new candidate' button in the window between SOPN uploaded and the ballot being locked. This isn't a useful thing to ask someone to log in for, most of the time. 25129bb
In ea384b8 I revert the earlier change to hide the button if we have a SOPN, but I do mark it as a secondary CTA. This means it's still possible, but it's not competing on the page to be the main CTA.
Move all SOPN related CTAs to the top of the page
When we have a SOPN we:
This groups all the 'Do a thing with a SOPN' actions to one place, and hopefully makes things a little clearer.