Skip to content

Conversation

@dmlvr
Copy link
Contributor

@dmlvr dmlvr commented Oct 22, 2025

No description provided.

@dmlvr dmlvr self-assigned this Oct 22, 2025
@dmlvr dmlvr added the 25_2 label Oct 22, 2025
@dmlvr dmlvr marked this pull request as ready for review October 23, 2025 07:31
@dmlvr dmlvr requested a review from a team as a code owner October 23, 2025 07:31
@Copilot Copilot AI review requested due to automatic review settings October 23, 2025 07:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where menu items in the Filter Builder popup were being truncated. The fix addresses the positioning behavior of the dropdown by changing how it handles parent scrolling and by removing a CSS positioning constraint.

Key changes:

  • Modified popup configuration to close on scroll instead of repositioning
  • Removed position: relative CSS rule that was causing truncation
  • Updated the corresponding test to verify the new close-on-scroll behavior

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/js/__internal/filter_builder/m_filter_builder.ts Changed popup behavior from container-based positioning to scroll-triggered hiding
packages/devextreme-scss/scss/widgets/base/filterBuilder/_index.scss Removed position: relative CSS rule that contributed to menu truncation
e2e/testcafe-devextreme/tests/common/filterBuilder/filterBuilderScrolling.ts Updated test to verify popup closes on scroll instead of moving with scroll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant