1193 font stack #31426
Open
1193 font stack #31426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm typography consistency
…mproved cross-platform typography consistency
…s-platform typography consistency
…graphy consistency
This reverts commit 7067602.
…and test files for consistency.
…cy across stylesheets and test files.
…ily declarations for consistency across stylesheets
There was a problem hiding this comment.
Pull Request Overview
This PR updates the font stack definitions across the codebase to use proper case for "BlinkMacSystemFont" (instead of lowercase "blinkmacsystemfont"). The change aligns with standard naming conventions where BlinkMacSystemFont is typically written in PascalCase.
Key Changes
- Updated font-family declarations across SCSS theme files (generic, material, fluent)
- Synchronized test expectations to match the new capitalization
- Disabled stylelint's
value-keyword-caserule to allow mixed-case font names
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/core/license/trial_panel.client.ts | Updated trial panel font stack with properly cased BlinkMacSystemFont |
| packages/devextreme-scss/scss/widgets/generic/_colors.scss | Corrected BlinkMacSystemFont capitalization in generic theme |
| packages/devextreme-scss/scss/widgets/material/_colors.scss | Corrected BlinkMacSystemFont capitalization in material theme |
| packages/devextreme-scss/scss/widgets/fluent/_colors.scss | Corrected BlinkMacSystemFont capitalization in fluent theme |
| packages/devextreme-scss/.stylelintrc.json | Disabled value-keyword-case rule to support mixed-case font names |
| .stylelintrc.json | Added root-level stylelint config with value-keyword-case disabled |
| packages/devextreme-themebuilder/tests/modules/compiler.test.ts | Updated test expectations for corrected font name |
| packages/devextreme-themebuilder/tests/modules/compile-manager.test.ts | Updated test expectations for corrected font name |
| packages/devextreme-themebuilder/tests/data/scss/widgets/generic/_colors.scss | Updated test fixture with corrected font name |
| packages/devextreme-themebuilder/tests/data/compilation-results/no-changes-meta.ts | Updated test data with corrected font name |
| packages/devextreme-themebuilder/tests/data/compilation-results/no-changes-css.ts | Updated test data with corrected font name |
packages/devextreme/js/__internal/core/license/trial_panel.client.ts
Outdated
Show resolved
Hide resolved
| /** | ||
| * $name 10. Font family | ||
| * $type text | ||
| */ |
There was a problem hiding this comment.
[nitpick] The stylelint disable comment was removed, but the line no longer violates value-keyword-case since the rule has been disabled in the stylelint configuration. The change is correct, but consider adding a comment explaining why mixed-case font names are intentionally used here (e.g., '// Using proper PascalCase for BlinkMacSystemFont').
Suggested change
| */ | |
| */ | |
| // Using proper casing for font family names as required by platforms (e.g., PascalCase for BlinkMacSystemFont) |
packages/devextreme/js/__internal/core/license/trial_panel.client.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]> Signed-off-by: Denis Malykh <[email protected]>
| * $type text | ||
| */ | ||
| $base-font-family: segoe ui, -apple-system, blinkmacsystemfont, avenir next, avenir, helvetica neue, adwaita sans, cantarell, ubuntu, roboto, noto, helvetica, arial, sans-serif !default; // stylelint-disable-line value-keyword-case | ||
| $base-font-family: segoe ui, -apple-system, BlinkMacSystemFont, avenir next, avenir, helvetica neue, adwaita sans, cantarell, ubuntu, roboto, noto, helvetica, arial, sans-serif !default; |
There was a problem hiding this comment.
The inline stylelint-disable comment was removed. Ensure this removal is intentional, as it may have been suppressing legitimate linting warnings for the lowercase 'segoe ui' value, which remains in the font stack.
Suggested change
| $base-font-family: segoe ui, -apple-system, BlinkMacSystemFont, avenir next, avenir, helvetica neue, adwaita sans, cantarell, ubuntu, roboto, noto, helvetica, arial, sans-serif !default; | |
| $base-font-family: Segoe UI, -apple-system, BlinkMacSystemFont, avenir next, avenir, helvetica neue, adwaita sans, cantarell, ubuntu, roboto, noto, helvetica, arial, sans-serif !default; |
VasilyStrelyaev
approved these changes
Oct 24, 2025
ajivanyandev
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.