CP: Fix React DataGrid SimpleArray demo: Remove defaultColumns prop #31434
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artem-kurchenko
commented
Oct 23, 2025
artem-kurchenko
commented
- Remove defaultColumns prop which is redundant when columns are explicitly defined
- Use Column components mapped from columns array
- Remove defaultColumns prop which is redundant when columns are explicitly defined - Use Column components mapped from columns array for better clarity
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a redundancy in the React DataGrid SimpleArray demo by removing the defaultColumns prop that was unnecessary when columns are explicitly defined through Column components.
Key changes:
- Removed redundant
defaultColumnsprop from DataGrid component - Retained explicit Column component mapping which properly defines the grid columns
AlisherAmonulloev
previously approved these changes
Oct 23, 2025
Alyar666
previously approved these changes
Oct 23, 2025
artem-kurchenko
dismissed stale reviews from Alyar666 and AlisherAmonulloev
via
6534a33
AlisherAmonulloev
approved these changes
Oct 24, 2025
Alyar666
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.