-
Notifications
You must be signed in to change notification settings - Fork 652
QUnit tests: fixed ui.widgets runner stall by removing excessive tests #31448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 25_2
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a performance issue in the QUnit test runner by reducing the number of test cases in the TreeView scrolling tests. The change removes an excessive nested loop that was generating a large number of redundant test combinations, replacing it with a more targeted set of tests.
Key changes:
- Removed the nested
rtlEnabledloop that was generating 2x the number of test cases - Reduced
keysToScrollarray from 6 items to 2 items for the main test configurations - Added a single explicit test case for
rtlEnabled: truewith the most comprehensive settings
packages/devextreme/testing/tests/DevExpress.ui.widgets/treeView.scrolling.tests.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
packages/devextreme/testing/tests/DevExpress.ui.widgets/scrollable.genericTheme.tests.js
Outdated
Show resolved
Hide resolved
02c8b13 to
b807b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
packages/devextreme/testing/tests/DevExpress.ui.widgets/drawer.scenarios.tests.js:1
- Duplicate commented-out QUnit.skip lines should be removed. The first occurrence (line 219) is sufficient if this code is being kept for reference.
import $ from 'jquery';
No description provided.