Skip to content

Conversation

@juleari
Copy link
Contributor

@juleari juleari commented Oct 24, 2025

No description provided.

@juleari juleari self-assigned this Oct 24, 2025
@juleari juleari added the 25_2 label Oct 24, 2025
@juleari juleari requested a review from a team as a code owner October 24, 2025 08:35
@Copilot Copilot AI review requested due to automatic review settings October 24, 2025 08:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a performance issue in the QUnit test runner by reducing the number of test cases in the TreeView scrolling tests. The change removes an excessive nested loop that was generating a large number of redundant test combinations, replacing it with a more targeted set of tests.

Key changes:

  • Removed the nested rtlEnabled loop that was generating 2x the number of test cases
  • Reduced keysToScroll array from 6 items to 2 items for the main test configurations
  • Added a single explicit test case for rtlEnabled: true with the most comprehensive settings

@Copilot Copilot AI review requested due to automatic review settings October 24, 2025 11:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@Copilot Copilot AI review requested due to automatic review settings October 24, 2025 12:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

packages/devextreme/testing/tests/DevExpress.ui.widgets/drawer.scenarios.tests.js:1

  • Duplicate commented-out QUnit.skip lines should be removed. The first occurrence (line 219) is sufficient if this code is being kept for reference.
import $ from 'jquery';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant