Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 구글 애널리틱스 적용 #357

Merged
merged 4 commits into from
May 28, 2024
Merged

feat: 구글 애널리틱스 적용 #357

merged 4 commits into from
May 28, 2024

Conversation

DongjaJ
Copy link
Member

@DongjaJ DongjaJ commented May 27, 2024

📌 이슈번호

📗 요구 사항과 구현 내용

📖 구현 스크린샷

📖 PR 포인트 & 궁금한 점

@DongjaJ DongjaJ linked an issue May 27, 2024 that may be closed by this pull request
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fedc-4-tmi-homers-off ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 6:18am

Copy link

Copy link

GBAJS754
GBAJS754 previously approved these changes May 27, 2024
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..? 대소문자 차이가 있나용..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요건 index.html 저장하면 자동으로 소문자로 변하네요.
index.html 내부의 ga 코드들은 삭제해도 react-ga4가 알아서 해주는 거같아서 제거했습니다.

index.html Outdated
@@ -33,6 +36,16 @@
/>

<meta name="robots" content="All" />
<script async src="https://www.googletagmanager.com/gtag/js?id=G-ZP5HX3Z90G"></script>
<script>
Copy link
Collaborator

@GBAJS754 GBAJS754 May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 스크립트를 App에서 작성해도 되지않나요..?🧐 따로 index.html에서 작성하신 이유가 궁금해용!

Copy link

Copy link

@DongjaJ DongjaJ merged commit 9490c29 into main May 28, 2024
7 checks passed
@DongjaJ DongjaJ deleted the feat/346 branch May 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

구글 애널리틱스 추가
2 participants