Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-client): let iron-svelte-client use automatic token generation #707

Merged
merged 10 commits into from
Mar 24, 2025

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Mar 19, 2025

iron-svelte-client.auto.token.gen.mp4

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README for iron-svelte-client to add instructions for automatic token generation using the tokengen project and the Rust toolchain.

  • Added a new "Automatic Token Generation" section with prerequisites and step-by-step guidance.
  • Retained the existing "Manual token generation" guidance for cases without the Rust toolchain.
Files not reviewed (1)
  • web-client/iron-svelte-client/src/lib/login/login.svelte: Language not supported
Comments suppressed due to low confidence (1)

web-client/iron-svelte-client/README.md:94

  • [nitpick] Consider using consistent title case for all section headings (e.g., 'Manual Token Generation') to improve readability and maintain uniformity.
#### Manual token generation

@irvingoujAtDevolution irvingoujAtDevolution changed the title feat(web-client): let iron-svelte-client use automatic code generation feat(web-client): let iron-svelte-client use automatic token generation Mar 19, 2025
Copy link

github-actions bot commented Mar 19, 2025

Coverage Report 🤖 ⚙️

Past:
Total lines: 30334
Covered lines: 19464 (64.17%)

New:
Total lines: 30334
Covered lines: 19465 (64.17%)

Diff: +0.00%

[this comment will be updated automatically]

Copy link

@kristahouse kristahouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irvingoujAtDevolution irvingoujAtDevolution merged commit bceb6c1 into master Mar 24, 2025
9 checks passed
@irvingoujAtDevolution irvingoujAtDevolution deleted the use-token-server branch March 24, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants