1.17 updates & Sharding version #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my perspective, the counter wasn't accounting for the row offset from the top, we simply just add on the row length to account for that and aswell as in the counter we add 1 since that doesn't occur if i is equal to lastElementLastCompleteRow
Maybe fix getCenteredInOrder
Courtesy of ponycau
Fix tab completion error
The just-saved default config wont have suddenly changed between the save and the reload. All this does is force every serialisable object to be re-initialised, probably creating a whole bunch of unnecessary database connections, item stacks, etc.
…o main * 'master' of https://github.com/Civclassic/CivModCore: Fix tab completion error Maybe fix getCenteredInOrder
Add EnumSetting
Remove unnecessary config reload
Apparently test classes have to be suffixed with "Tests"
Also removed move-canceller.. you can't move beacons with pistons anyway
Stop console warnings
So apparently VOID_AIR and CAVE_AIR are valid item materials
and organised enchants.yml into versions for easier updating
Exception doesn't actually catch ALL thrown, so catch Throwable instead.
…o 16+17 # Conflicts: # pom.xml # src/main/java/org/bukkit/pseudo/PseudoServer.java
Basically Minecraft is bad, and Paper doesn't completely fix it
Fix NMS skin lookup lag (by ripkilling the Future so they don't happen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ori's 1.17 updates including Max's player storage rework so that player settings are stored in a players nbt