-
Notifications
You must be signed in to change notification settings - Fork 67
Iridescent fresnel, bxdfs #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keptsecret
wants to merge
20
commits into
master
Choose a base branch
from
iridescence_bxdf
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4b3224a
initial iridescent fresnel, only single channel ior
keptsecret 9c71906
iridescent fresnel does rgb IOR, use in brdf
keptsecret 0f51306
some bug fixes
keptsecret f205d4e
replace loop for vector operations in fresnel
keptsecret f6daa6f
added iridescent btdf
keptsecret 09402ea
added unit tests
keptsecret a77c337
merge bxdfs, fix conflicts
keptsecret aa0f6e8
latest example
keptsecret d2cb193
moved colorspace transform mats into struct functions
keptsecret 33fc955
some more colorspace utility
keptsecret 0f6c7a2
merge latest bxdf_fixes, fix conflicts
keptsecret d8b6773
restore encode/decode matrices
keptsecret 65239d9
colorspace specific dominant wavelengths (still missing ACES), use gl…
keptsecret 9a8b77e
update iridescent fresnel to match fresnel concept
keptsecret 702ec8d
Merge branch 'master' into iridescence_bxdf
keptsecret 76ad0ed
minor typo fixes
keptsecret 53c930f
minor fixes to cook torrance, ndf infinity, move util functions into …
keptsecret 23de8ed
changes to angle adding usage
keptsecret ff9e03f
better orthonormality for H
keptsecret 18b3922
minor change to ggx clamp
keptsecret File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a new struct for this e.g.
ThinFilmConductor, its separate functionality, same for the dielectricThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will note that it's the same calculation all the way until the end where the regular fresnel just returns
(Rs + Rp) * 0.5instead ofinout Rs, RpThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then return
complex_t<T>and treat Rs as Real and Rp as imag, or make a struct to hold Polarized Reflectance and DRY the code