Add a structure that holds information about vulkan devices (Vulkan Profile JSON) #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Erfan-Ahmadi note that we can't use GPUinfo.org cause its on AGPL license, so its either |
… write information about available extensions
| renderdoc_api_t* const m_rdoc_api; | ||
| const VkPhysicalDevice m_vkPhysicalDevice; | ||
|
|
||
| core::string& m_profile; |
There was a problem hiding this comment.
what are you doing!?
you do realize the vector grows and reallocates ? you need an index into it!
There was a problem hiding this comment.
Right, I forgot that it might behave like that. Let me correct that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO list: