Skip to content

Added the equals sign towards the top for more intuiative design #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KallamSamad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added the equals sign towards the top for more intuiative design #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ <h1 id="calc-style">Calculator<i class="bx bx-calculator"></i></h1>
<input type="text" title="You can directly type." id="screen" maxlength="30" readonly />
<div class="calc-buttons">
<br />
<button class="button triggers" data-text="enter">
<h1>=</h1>
</button>
Comment on lines +36 to +38
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The equals button is now positioned outside of any function grouping div (functions-one, functions-two, functions-three), which breaks the consistent structure of the calculator layout. Consider wrapping it in an appropriate container div or moving it to a more logical position within the existing button grid structure.

Copilot uses AI. Check for mistakes.
<div class="functions-one">
<button class="button numbers" data-text="7">
<h1>7</h1>
Expand Down Expand Up @@ -232,9 +235,7 @@ <h1>tanh</h1>
</div>
<br />
<div class="functions-three">
<button class="button triggers" data-text="enter">
<h1>=</h1>
</button>

</div>
Comment on lines 237 to 239
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions-three div is now empty after removing the equals button. This empty div should either be removed entirely or repurposed with other functionality to avoid unnecessary DOM elements.

Copilot uses AI. Check for mistakes.
<div class="historyDisplay">
<h2>HISTORY</h2>
Expand Down