Skip to content

add log button #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baishnvi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add log button #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ <h1 id="calc-style">Calculator<i class="bx bx-calculator"></i></h1>
<button class="button complex-stuff">
tanh
</button>
<button class="button" id="logBtn">
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button is missing the "complex-stuff" class that all other buttons in the "more functions" section have (see lines 94-175). This class is used for styling and potentially for the button event handling system. The inconsistent class assignment may cause visual inconsistencies or prevent the button from being properly handled by the main event listener loop.

Suggested change
<button class="button" id="logBtn">
<button class="button complex-stuff" id="logBtn">

Copilot uses AI. Check for mistakes.
log</button>
Comment on lines +176 to +177
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button labeled 'log' creates ambiguity and duplication with the existing 'log₁₀' button at line 104-106. Both buttons would calculate the base-10 logarithm using Math.log10(). In mathematics and computing, 'log' without a subscript is ambiguous - it can mean either log₁₀ (common in mathematics) or ln (natural log, common in programming). The codebase already has explicit buttons for log₁₀, log₂, and logₑ, making this additional 'log' button redundant and potentially confusing to users.

Suggested change
<button class="button" id="logBtn">
log</button>

Copilot uses AI. Check for mistakes.
</div>
</div>
<button class="solve-quadratic" onclick=" solveQuadratic()">SOLVE EQUATION</button>
Expand Down
11 changes: 11 additions & 0 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,17 @@ Array.prototype.forEach.call(buttons, function (button) {
}
});
});
document.getElementById('logBtn').addEventListener('click', log);
Comment on lines 245 to +248
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button text 'log' is already included in the exclusion list at line 136, suggesting it was planned to be handled in the main event listener. However, there's no corresponding handler in the if-else chain (lines 161-245) for when trimmedButtonValue === 'log'. This creates an incomplete implementation where the button is recognized but not handled through the standard flow. The proper solution would be to add a handler in the main event listener chain, similar to how log10, log2, and loge are handled at lines 203-208.

Suggested change
}
});
});
document.getElementById('logBtn').addEventListener('click', log);
} else if (trimmedButtonValue === 'log') {
log();
}
});
});

Copilot uses AI. Check for mistakes.
Comment on lines 245 to +248
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new log button bypasses the established button handling pattern. All other calculator buttons with the "complex-stuff" class are handled through the main Array.prototype.forEach.call event listener (lines 104-247). Using getElementById with a separate event listener creates inconsistency. Additionally, when this button is clicked, it will trigger both this handler AND the main button handler at line 104, potentially causing the function to execute twice or behave unexpectedly.

Suggested change
}
});
});
document.getElementById('logBtn').addEventListener('click', log);
} else if (trimmedButtonValue === 'log') {
log();
}
});
});

Copilot uses AI. Check for mistakes.
function log() {
const num = parseFloat(display.value);
if (isNaN(num) || num <= 0) {
openToast('error', 'Error', 'Enter a positive number to calculate log');
return;
}
Comment on lines +251 to +254
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the error handling for non-positive numbers is a good addition, it creates inconsistency with the existing log10() function (line 515-518) which performs the same operation but lacks this validation. When users try log₁₀ of a negative number, they get NaN displayed, but with this new 'log' button they would get an error toast. This inconsistent behavior for the same mathematical operation could confuse users. The validation logic should either be added to all logarithm functions (log10, log2, loge) or removed from this one to maintain consistency.

Suggested change
if (isNaN(num) || num <= 0) {
openToast('error', 'Error', 'Enter a positive number to calculate log');
return;
}

Copilot uses AI. Check for mistakes.
display.value = Math.log10(num);
resultDisplayed = true;
manageLocalStorage(display.value);
}
Comment on lines +248 to +258
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function duplicates the existing log10() function at line 515-518, which already calculates the base-10 logarithm using Math.log10(). The existing implementation also handles the same operation and follows the established pattern of using eval() for consistency with other math functions. Having two functions that do the same thing creates maintenance issues and confusion.

Suggested change
document.getElementById('logBtn').addEventListener('click', log);
function log() {
const num = parseFloat(display.value);
if (isNaN(num) || num <= 0) {
openToast('error', 'Error', 'Enter a positive number to calculate log');
return;
}
display.value = Math.log10(num);
resultDisplayed = true;
manageLocalStorage(display.value);
}
document.getElementById('logBtn').addEventListener('click', log10);

Copilot uses AI. Check for mistakes.
Comment on lines +249 to +258
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The play() function should be called to provide audio feedback, consistent with all other calculator operations. See line 106 in the main button handler and line 74 in error handling for examples. The audio feedback is an important UX element that should be maintained across all operations.

Copilot uses AI. Check for mistakes.

// Prevents multiple decimal points from being typed through keyboard
function isNumber(num) {
Expand Down