Use fps for scoring and add skip-wrong-fps CLI option #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #748
Use FPS to score the subtitles. A matching FPS counts less than a release group match, but more than source match (or resolution and codecs.)
This will increase the score of the subtitles with the same FPS (with a relative error of 1%) as the video.
On top of that, this PR adds a
skip-wrong-fpsCLI option to just ignore the subtitles with a known FPS that is different from the video FPS (if it could be detected).Also
hearing_impairedis not contributing anymore to the score.This is a breaking change as the scores of all the subtitles will change.
The only provider that provides an FPS for (some of) the subtitles is
opensubtitlescom