Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch 2.0 Compatibility #201

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Torch 2.0 Compatibility #201

merged 1 commit into from
Aug 30, 2023

Conversation

atong01
Copy link
Member

@atong01 atong01 commented Aug 28, 2023

Test all pytorch versions

Bump allowable torch version requirement

Fix typo

Fix typo

Fix typo

Fix typo

Add update version in torchdyn.__version__

Ignore incompatible versions

Ignore incompatible versions

Fix versioning

temp remove fail fast, remove torch vision

Exclude torch=1.13 python=3.11

Exclude 1.8.1 as hangs tests

Test all pytorch versions

skip complex test for pytorch < 1.11.0

Skip incompatible pytorch versions

remove swp

OS coverage update

OS coverage update 2

Cleanup PR

Bump required torch version to 1.8.1

Bump allowable torch version requirement
@atong01
Copy link
Member Author

atong01 commented Aug 28, 2023

Fixes #200

Skips a failing test with complex ODEs for torch <1.11.0.

Reworks the GitHub CI Action to test against torch versions. Notes specific version compatibility.

@atong01 atong01 requested a review from Zymrael August 28, 2023 21:12
@atong01
Copy link
Member Author

atong01 commented Aug 28, 2023

Assuming tests pass and @Zymrael approves, would like to push a release 1.0.6 that does not enforce torch<2.0

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (92dd9ba) 64.59% compared to head (2b0de91) 64.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   64.59%   64.59%           
=======================================
  Files          27       27           
  Lines        1881     1881           
=======================================
  Hits         1215     1215           
  Misses        666      666           
Files Changed Coverage Δ
torchdyn/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zymrael
Copy link
Member

Zymrael commented Aug 30, 2023

Looks good, thanks @atong01!

@Zymrael Zymrael merged commit d6772ab into DiffEqML:master Aug 30, 2023
57 checks passed
@atong01
Copy link
Member Author

atong01 commented Aug 30, 2023

Cool. Will release 1.0.6 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants