-
Notifications
You must be signed in to change notification settings - Fork 3
chore: npm audit fix and ESLint 9 migration #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return () => player?.dispose(); | ||
| }, [src]); | ||
| }, [autoplay, controls, fluid, onError, options, player, src]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Video player disposed on every parent rerender
The useEffect now depends on onError and returns a disposer, so any parent rerender that recreates the handler (e.g., onError={() => setPlayerError(true)} in MediaContentItem) triggers the cleanup, disposes the player, and then re-enters the effect with the stale player reference still truthy. Because no new player is created, the subsequent player.src call runs on a disposed instance, causing playback to stop or throw as soon as the parent component updates state (selecting a carousel item, handling errors, etc.).
Useful? React with 👍 / 👎.
Summary
Testing
Vercel Preview Validation Plan (E2E Click-Around)